On Fri, Jun 25, 2021 at 6:56 PM Taylor Simpson <[email protected]> wrote:
> > > On Sat, Jun 19, 2021 at 4:49 AM Alessandro Di Federico via < > [email protected]> wrote: > >> From: Niccolò Izzo <[email protected]> >> >> Signed-off-by: Alessandro Di Federico <[email protected]> >> Signed-off-by: Niccolò Izzo <[email protected]> >> --- >> > > > > + .text >> + .globl _start >> + >> +_start: >> + { >> + call init >> + } >> + { >> + r0=#1 >> + memw(sp+#0)=r0.new >> + } >> > > You haven't set up the stack, so you shouldn't use sp. Even if the stack > were set up, you should allocframe first. > > My apologies - the stack *is* set up in linux-user mode. So, it is OK to reference sp after you do an allocframe. You can disregard the other comments in the review about setting up the stack. Thanks, Taylor
