Yes, you are right. I think keep the old pattern is better. ________________________________ From: Cornelia Huck <[email protected]> Sent: Tuesday, June 22, 2021 7:39 PM To: Al Cho <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> Cc: Claudio Fontana <[email protected]>; Al Cho <[email protected]>; Claudio Fontana <[email protected]>; David Hildenbrand <[email protected]> Subject: Re: [RFC v5 06/13] target/s390x: start moving TCG-only code to tcg/
On Tue, Jun 22 2021, "Cho, Yu-Chen" <[email protected]> wrote: > move everything related to translate, as well as HELPER code in tcg/ > > mmu_helper.c stays put for now, as it contains both TCG and KVM code. > > The internal.h file is renamed to s390x-internal.h, because of the > risk of collision with other files with the same name. > > After the reshuffling, update MAINTAINERS accordingly. > Make use of the new directory: > > target/s390x/tcg/ (...) > diff --git a/MAINTAINERS b/MAINTAINERS > index 636bf2f536..d05dcc22e0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -294,7 +294,7 @@ S390 TCG CPUs > M: Richard Henderson <[email protected]> > M: David Hildenbrand <[email protected]> > S: Maintained > -F: target/s390x/ > +F: target/s390x/tcg > F: hw/s390x/ > F: disas/s390.c > F: tests/tcg/s390x/ This means that the pattern for tcg won't cover those files anymore that are relevant for both tcg and kvm (e.g. cpu models). Maybe those files need to be enumerated? Or keep the old pattern?
