On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote:
Reviewed-by: Richard Henderson <[email protected]>
Acked-by: Corey Minyard <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>

Reviewed-by: BALATON Zoltan <[email protected]>

---
hw/display/sm501.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 8789722ef27..f276276f7f1 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -1036,8 +1036,9 @@ static void sm501_i2c_write(void *opaque, hwaddr addr, 
uint64_t value,
                int res = i2c_start_transfer(s->i2c_bus,
                                             s->i2c_addr >> 1,
                                             s->i2c_addr & 1);
-                s->i2c_status |= (res ? SM501_I2C_STATUS_ERROR : 0);
-                if (!res) {
+                if (res) {
+                    s->i2c_status |= SM501_I2C_STATUS_ERROR;
+                } else {
                    int i;
                    for (i = 0; i <= s->i2c_byte_count; i++) {
                        res = i2c_send_recv(s->i2c_bus, &s->i2c_data[i],

Reply via email to