On Mon, Jun 14, 2021 at 06:04:13PM -0300, Fabiano Rosas wrote: > "Bruno Larsen (billionai)" <[email protected]> writes: > > > +/* > > + * These correspond to the mmu_idx values computed in > > + * hreg_compute_hflags_value. See the tables therein > > + */ > > +static inline bool mmuidx_pr(int idx) { return !(idx & 1); } > > +/* > > + * If we want to use these macros for hash-style MMUs, we need to > > + * add an if or another macro here. > > + */ > > Don't these work just fine for hash as well? Except for Booke.
Right, I think we want to restrict these to BookS mmus, but I don't
think we need to restrict to radix.
>
> > +static inline bool mmuidx_real(int idx) { return idx & 2; }
> > +static inline bool mmuidx_hv(int idx) { return idx & 4; }
> > +
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
