Hi,
> > +# @arch: module architecture.
>
> Semantics?
>
> Should this be enum SysEmuTarget?
Probably, will check ...
> > +# @opts: qemu opts implemented by module.
>
> Is this the name of a QemuOptsList?
>
> Since this isn't a list, a module can only ever provide one
> QemuOptsList. Sure that's okay?
For the current two in-tree cases yes, and I don't expect this to change
in the future. We could turn this into a list though to make it
future-proof.
> > +{ 'struct': 'Modules',
> > + 'data': { 'list' : ['ModuleInfo']}}
>
> This defines only types, no QMP commands or events. Why do you need the
> types to be QAPI types?
Want re-use the code to serialize/parse json from/to structs.
(see patches #3 + #13).
> > --- a/qapi/qapi-schema.json
> > +++ b/qapi/qapi-schema.json
> > @@ -93,3 +93,4 @@
> > { 'include': 'audio.json' }
> > { 'include': 'acpi.json' }
> > { 'include': 'pci.json' }
> > +{ 'include': 'modules.json' }
>
> Is this the place you want the section to be? Remember, generated
> documentation follows source order.
Ah, *this* the ordering is important for. I'll check, was just
appending to the end of the list ...
thanks,
Gerd
