Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled

[Richard Henderson]

On 5/24/21 3:56 PM, Swetha Joshi wrote:
From: Swetha <swjo...@microsoft.com>
Signed-off-by: Swetha <swjo...@microsoft.com>

What are you trying to accomplish?
That's what belongs in the commit message that you omitted.

+    bool acpi_enabled = false;
+#ifdef CONFIG_ARM_VIRT
      bool acpi_enabled = virt_is_acpi_enabled(vms);

Of course this doesn't compile, having declared acpi_enabled twice.  So you 
have clearly not tested this patch sufficiently.

The cc to qemu-trivial is unwarranted.


r~