Re: [RFC PATCH 11/11] hw/isa: Rename isabus singleton as 'g_isabus'

[Stefan Hajnoczi]

On Tue, May 18, 2021 at 11:55:45PM +0200, Philippe Mathieu-Daudé wrote:
> @@ -55,7 +53,10 @@ static const TypeInfo isa_bus_info = {
>  ISABus *isa_bus_new(DeviceState *dev, MemoryRegion* address_space,
>                      MemoryRegion *address_space_io, Error **errp)
>  {
> -    if (isabus) {
> +    static ISABus *g_isabus;

QEMU doesn't use Hungarian notation, g_isabus isn't a global variable so
the prefix is confusing, and g_ conflicts with GLib's namespace so the
rename is odd. I suggest keeping the name unchanged and making the
commit message "remove the global isabus variable".

signature.asc
Description: PGP signature