18.05.2021 17:26, Max Reitz wrote:
On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote:
Now block-copy will crash if user don't set progress meter by
block_copy_set_progress_meter(). copy-before-write filter will be used
in separate of backup job, and it doesn't want any progress meter (for
now). So, allow not setting it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
---
block/block-copy.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
Makes me wonder whether an “if (not NULL)” check in progress_meter.h wouldn’t
be a nice addition, but:
IMHO it isn't. It's unusual to check if (obj is not NULL) in all obj API
functions.. The only place where it is usual is obj_free() like functions.
Reviewed-by: Max Reitz <[email protected]>
Thanks!
--
Best regards,
Vladimir
