Hi Salil,

On 2021/5/18 4:48, Salil Mehta wrote:
From: Qemu-arm [mailto:[email protected]]
On Behalf Of Yanan Wang
Sent: Sunday, May 16, 2021 11:29 AM
To: Peter Maydell <[email protected]>; Andrew Jones
<[email protected]>; Michael S . Tsirkin <[email protected]>; Igor Mammedov
<[email protected]>; Shannon Zhao <[email protected]>; Alistair
Francis <[email protected]>; David Gibson
<[email protected]>; [email protected]; [email protected]
Cc: Song Bao Hua (Barry Song) <[email protected]>; zhukeqian
<[email protected]>; yangyicong <[email protected]>; Zengtao (B)
<[email protected]>; Wanghaibin (D) <[email protected]>;
yuzenghui <[email protected]>; Paolo Bonzini <[email protected]>;
Philippe Mathieu-Daudé <[email protected]>
Subject: [RFC PATCH v3 4/9] hw/arm/virt: Initialize the present cpu members

We create and initialize a cpuobj for each present cpu in
machvirt_init(). Now we also initialize the cpu member of
structure CPUArchId for each present cpu in the function.
[...]

          qdev_realize(DEVICE(cpuobj), NULL, &error_fatal);
+
+        /*
+         * As ARM cpu hotplug is not supported yet, we initialize
+         * the present cpu members here.
+         */
+        machine->possible_cpus->cpus[n].cpu = cpuobj;

when vcpu Hotplug is not supported yet, what necessitates this change now?

The initialization will gives a way to determine whether a CPU is present or not. At least, for now it will be used when generating ACPI tables, e.g. DSDT, MADT.
See patch 5 and 6.

Thanks,
Yanan
.

Reply via email to