On Sat, May 15, 2021 at 07:37:13PM +0200, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé <f4...@amsat.org>
>
> Looking at the MV64340 model source, there is a dependency on the
> 8259 interrupt controller:
>
> 523 case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG:
> 524 /* FIXME: Should this be sent via the PCI bus somehow? */
> 525 if (s->gpp_int_level && (s->gpp_value & BIT(31))) {
> 526 ret = pic_read_irq(isa_pic);
> 527 }
> 528 break;
>
> Add it to Kconfig to avoid the following build failure:
>
> /usr/bin/ld: libcommon.fa.p/hw_pci-host_mv64361.c.o: in function
> `mv64361_read':
> hw/pci-host/mv64361.c:526: undefined reference to `isa_pic'
> /usr/bin/ld: hw/pci-host/mv64361.c:526: undefined reference to
> `pic_read_irq'
>
> Fixes: dcdf98a9015 ("hw/pci-host: Add emulation of Marvell MV64361 PPC system
> controller")
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Acked-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> hw/pci-host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
> index 79c20bf28bb..9dc0d761815 100644
> --- a/hw/pci-host/Kconfig
> +++ b/hw/pci-host/Kconfig
> @@ -76,3 +76,4 @@ config SH_PCI
> config MV64361
> bool
> select PCI
> + select I8259
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
