On Sat, 15 May 2021, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé <f4...@amsat.org>
While the ATI VGA device isn't a requisite (no crash without it):
$ qemu-system-ppc -M pegasos2
qemu-system-ppc: standard VGA not available
it is useful to have it with the Pegasos2 machine:
$ qemu-system-ppc -M pegasos2 -vga none -bios pegasos2.rom -device
ati-vga,romfile=
qemu-system-ppc: -device ati-vga,romfile=: 'ati-vga' is not a valid device
model name
Add it as an implicit Kconfig dependency.
Fixes: ba7e5ac18e7 ("hw/ppc: Add emulation of Genesi/bPlan Pegasos II")
You can list it as a fix but I regard this more an enhancement or
amandment to that commit as it was not broken in this regard as the commit
message above also explains. To me Fixes tag means more that something was
broken in that commit that this one patches up but I don't care much about
this tag. It would probably make more sense in your other commits fixing
missing dependencies (although not clear which commit those fix as the
missing dependencies were probably also missing before the latest clean
ups).
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Acked-by: BALATON Zoltan <bala...@eik.bme.hu>
---
hw/ppc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index 2e4c56eb770..e36db08665a 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -77,6 +77,7 @@ config PEGASOS2
select SMBUS_EEPROM
# This should come with VT82C686
select ACPI_X86
+ imply ATI_VGA
config PREP
bool
