On Mon, Apr 19, 2021 at 10:55:40AM +0200, Emanuele Giuseppe Esposito wrote:
> @@ -210,7 +212,7 @@ static int replication_return_value(BDRVReplicationState
> *s, int ret)
> }
>
> if (ret < 0) {
> - s->error = ret;
> + qatomic_set(&s->error, ret);
> ret = 0;
> }
>
> @@ -307,6 +309,7 @@ out:
> return ret;
> }
>
> +/* Called with no I/O pending. */It would be clearer to refer to the specific guarantee that no I/O is pending, like "Called from a drained section". There are more comments like this one below.
signature.asc
Description: PGP signature
