On Tue, 13 Apr 2021 15:43:19 -0400 Eduardo Habkost <[email protected]> wrote:
> On Mon, Apr 12, 2021 at 11:44:29AM +0100, Peter Maydell wrote: > > On Mon, 12 Apr 2021 at 11:31, Philippe Mathieu-Daudé <[email protected]> > > wrote: > > > TIL MachineClass::reset(). > > > > > > - hw/hppa/machine.c > > > - hw/i386/pc.c > > > > > > Used to reset CPUs manually because CPUs aren't sysbus-reset. > > > > pc_machine_reset() is not resetting the CPUs -- it is > > re-resetting the APIC devices, which looks like it is a > > workaround for a reset-ordering or other problem. I'm not > > sure where the CPUs are being reset... > > CPU reset code was moved from pc.c:pc_cpu_reset() to > cpu.c:x86_cpu_machine_reset_cb() in commit 65dee3805259 > ("target-i386: move cpu_reset and reset callback to cpu.c"). > It's not clear to me why. it was for cpu hotplug support, so that is we would have CPU in well know initial state after realize is complete.
