On 5/1/21 12:18 AM, Peter Maydell wrote: > On Fri, 30 Apr 2021 at 23:17, Peter Maydell <[email protected]> wrote: >> Same thing is also a build failure on 32-bit hosts (where the types >> are genuinely different sizes): >> >> ../../hw/misc/aspeed_hace.c: In function 'do_hash_operation': >> ../../hw/misc/aspeed_hace.c:128:49: error: passing argument 3 of >> 'address_space_map' from incompatible pointer type >> [-Werror=incompatible-pointer-types] >> &iov[i].iov_len, false, >> ^ >> In file included from /home/peter.maydell/qemu/include/hw/sysbus.h:7:0, >> from >> /home/peter.maydell/qemu/include/hw/misc/aspeed_hace.h:12, >> from ../../hw/misc/aspeed_hace.c:14: >> /home/peter.maydell/qemu/include/exec/memory.h:2438:7: note: expected >> 'hwaddr * {aka long long unsigned int *}' but argument is of type >> 'size_t * {aka unsigned int *}' >> void *address_space_map(AddressSpace *as, hwaddr addr, >> ^~~~~~~~~~~~~~~~~ > > If you like you can repro this on the gitlab CI where we have > cross-build jobs for the 32-bit targets, eg: > https://gitlab.com/qemu-project/qemu/-/jobs/1227559504
Yes. It is time for me to migrate. I will send a fixed v2 when this is done. Thanks, C.
