Have taken care of it.please ignore PIDR2 changes in the current patchset ,will update the latest changes in the next patchset version
Thanks Shashi On Apr 30 2021, at 6:09 am, Peter Maydell <[email protected]> wrote: > On Fri, 30 Apr 2021 at 00:36, <[email protected]> wrote: > > > > On Fri, 2021-04-16 at 18:21 +0100, Peter Maydell wrote: > > > On Thu, 1 Apr 2021 at 03:41, Shashi Mallela < > > > [email protected]> wrote: > > > > +#define GITS_PIDR2 0xFFE8 > > > > > > You probably don't want an offset for GITS_PIDR2 specifically. > > > Compare handling of GICD_IDREGS in the distributor emulation. > > > Tried re-using the GICD_IDREGS offset for GITS_PIDR2,but from testing > > > observed that the linux kernel driver and kvm-unit-tests both relied > > > on using the 0xFFE8 offset instead of 0xFFD0 (used by GICD & GICR) to > > > complete ITS initialization and setup > > I didn't mean "just put PIDR2 at the GICD_IDREGS offset", which > obviously won't work, I meant "implement the whole set of ID registers > (of which PIDR2 is one in the middle) in the same way we implement that > set on the other GIC components". > > -- PMM
