Re: [PATCH v2 3/7] target/ppc: Isolated SPR read/write callbacks

[Richard Henderson]

On 4/29/21 9:21 AM, Bruno Larsen (billionai) wrote:

diff --git a/target/ppc/spr_tcg.c.inc b/target/ppc/spr_tcg.c.inc
new file mode 100644
index 0000000000..48274dd52b
--- /dev/null
+++ b/target/ppc/spr_tcg.c.inc
@@ -0,0 +1,1033 @@
+#include "exec/translator.h"

All new files must have copyright header.

+/* I really see no reason to keep these gen_*_xer */
+/* instead of just leaving the code in the spr_*_xer */

Then just do that, as a separate patch, before or after.

@@ -8515,3 +8471,4 @@ void restore_state_to_opc(CPUPPCState *env, 
TranslationBlock *tb,
  {
      env->nip = data[0];
  }
+

Watch the extra whitespace at end of file.


r~