Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: [email protected] Subject: [RFC PATCH 00/27] Virtio sound card implementation === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 28acae8 virtio-snd: Add rx vq and stub handler f130077 virtio-snd: Add event vq and a handler stub ba43c58 virtio-snd: Add tx vq and handler d1fae3c virtio-snd: Add code to device unrealize function 5633fc1 virtio-snd: Replaced goto with if else df2aca8 virtio-snd: Add VIRTIO_SND_R_PCM_RELEASE handler 4d5b976 virtio-snd: Add VIRTIO_SND_R_PCM_STOP handler 9c792b2 virtio-snd: Add VIRITO_SND_R_PCM_START handler ad07e2c virtio-snd: Add callback for SWVoiceOut 6a9e47d virtio-snd: Add default configs to realize fn 75c62c8 virtio-snd: Add VIRTIO_SND_R_PCM_PREPARE handler 64043bd virtio-snd: Add VIRITO_SND_R_PCM_SET_PARAMS handle bb5fe5d virtio-snd: Add VIRTIO_SND_R_PCM_INFO handler 858de0e virtio-snd: Add stub for VIRTIO_SND_R_JACK_REMAP handler a1596e5 virtio-snd: Add VIRTIO_SND_R_JACK_INFO handler d303365 virtio-snd: Add control virtqueue handler 4c49f92 virtio-snd: Add macros for logging 504942a virtio-snd: Add code for the realize function d7fad34 virtio-snd: Add code for set config function f1d51f3 virtio-snd: Add code for get config function cfc404f virtio-snd: Add properties for class init b0b4fa2 virtio-snd: Add PCI wrapper code for VirtIOSound 0a0606a virtio-snd: Add device implementation structures e57488a virtio-snd: Add chmap control structures f8faf7e virtio-snd: Add PCM control structures ba1cc8b virtio-snd: Add jack control structures cc2413a virtio-snd: Add virtio sound header file === OUTPUT BEGIN === 1/27 Checking commit cc2413a852b8 (virtio-snd: Add virtio sound header file) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 97 lines checked Patch 1/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/27 Checking commit ba1cc8ba3399 (virtio-snd: Add jack control structures) 3/27 Checking commit f8faf7ec9a71 (virtio-snd: Add PCM control structures) 4/27 Checking commit e57488ae6767 (virtio-snd: Add chmap control structures) 5/27 Checking commit 0a0606abe96c (virtio-snd: Add device implementation structures) 6/27 Checking commit b0b4fa241458 (virtio-snd: Add PCI wrapper code for VirtIOSound) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 79 lines checked Patch 6/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/27 Checking commit cfc404f0d2ff (virtio-snd: Add properties for class init) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 138 lines checked Patch 7/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/27 Checking commit f1d51f3d3a6d (virtio-snd: Add code for get config function) 9/27 Checking commit d7fad34dacf1 (virtio-snd: Add code for set config function) 10/27 Checking commit 504942a2f235 (virtio-snd: Add code for the realize function) 11/27 Checking commit 4c49f923a5dd (virtio-snd: Add macros for logging) 12/27 Checking commit d3033655589b (virtio-snd: Add control virtqueue handler) WARNING: Block comments use a leading /* on a separate line #23: FILE: hw/audio/virtio-snd.c:104: +/* The control queue handler. Pops an element from the control virtqueue, total: 0 errors, 1 warnings, 83 lines checked Patch 12/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/27 Checking commit a1596e59b05f (virtio-snd: Add VIRTIO_SND_R_JACK_INFO handler) 14/27 Checking commit 858de0ed4483 (virtio-snd: Add stub for VIRTIO_SND_R_JACK_REMAP handler) 15/27 Checking commit bb5fe5d45c23 (virtio-snd: Add VIRTIO_SND_R_PCM_INFO handler) 16/27 Checking commit 64043bdef02c (virtio-snd: Add VIRITO_SND_R_PCM_SET_PARAMS handle) WARNING: line over 80 characters #35: FILE: hw/audio/virtio-snd.c:294: + virtio_snd_pcm_set_params *params) total: 0 errors, 1 warnings, 112 lines checked Patch 16/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/27 Checking commit 75c62c857884 (virtio-snd: Add VIRTIO_SND_R_PCM_PREPARE handler) WARNING: Block comments use a leading /* on a separate line #168: FILE: hw/audio/virtio-snd.c:526: + /* st->voice.out = AUD_open_out(&s->card, WARNING: Block comments use a leading /* on a separate line #175: FILE: hw/audio/virtio-snd.c:533: + /* st->voice.in = AUD_open_in(&s->card, total: 0 errors, 2 warnings, 210 lines checked Patch 17/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/27 Checking commit 6a9e47df0a16 (virtio-snd: Add default configs to realize fn) Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2830. Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2830. Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2831. ERROR: do not use C99 // comments #24: FILE: hw/audio/virtio-snd.c:686: + // set default params for all streams ERROR: Error messages should not contain newlines #44: FILE: hw/audio/virtio-snd.c:706: + error_setg(errp, "Can't initalize stream params.\n"); ERROR: Error messages should not contain newlines #49: FILE: hw/audio/virtio-snd.c:711: + error_setg(errp, "Can't prepare streams.\n"); ERROR: do not use C99 // comments #55: FILE: hw/audio/virtio-snd.c:717: + // TODO: For now the hda_fn_nid connects the starting streams to these ERROR: do not use C99 // comments #56: FILE: hw/audio/virtio-snd.c:718: + // jacks. This isn't working for now since the directions will be wrong ERROR: do not use C99 // comments #57: FILE: hw/audio/virtio-snd.c:719: + // for a few jacks. Similarly the capabilities are just placeholders. ERROR: unnecessary cast may hide bugs, use g_new0 instead #58: FILE: hw/audio/virtio-snd.c:720: + s->jacks[i] = (virtio_snd_jack *)g_malloc0(sizeof(virtio_snd_jack)); ERROR: line over 90 characters #61: FILE: hw/audio/virtio-snd.c:723: + s->jacks[i]->hda_reg_defconf = ((AC_JACK_PORT_COMPLEX << AC_DEFCFG_PORT_CONN_SHIFT) | ERROR: line over 90 characters #62: FILE: hw/audio/virtio-snd.c:724: + (AC_JACK_LINE_OUT << AC_DEFCFG_DEVICE_SHIFT) | ERROR: line over 90 characters #63: FILE: hw/audio/virtio-snd.c:725: + (AC_JACK_CONN_1_8 << AC_DEFCFG_CONN_TYPE_SHIFT) | ERROR: line over 90 characters #64: FILE: hw/audio/virtio-snd.c:726: + (AC_JACK_COLOR_GREEN << AC_DEFCFG_COLOR_SHIFT) | total: 11 errors, 0 warnings, 51 lines checked Patch 18/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/27 Checking commit ad07e2c375df (virtio-snd: Add callback for SWVoiceOut) WARNING: line over 80 characters #129: FILE: hw/audio/virtio-snd.c:575: + int curr_elem_size = iov_size(st->elems[i]->out_sg, st->elems[i]->out_num) total: 0 errors, 1 warnings, 183 lines checked Patch 19/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/27 Checking commit 9c792b226bf4 (virtio-snd: Add VIRITO_SND_R_PCM_START handler) 21/27 Checking commit 4d5b9762480e (virtio-snd: Add VIRTIO_SND_R_PCM_STOP handler) 22/27 Checking commit df2aca848dfb (virtio-snd: Add VIRTIO_SND_R_PCM_RELEASE handler) 23/27 Checking commit 5633fc14cfe7 (virtio-snd: Replaced goto with if else) 24/27 Checking commit d1fae3cd628b (virtio-snd: Add code to device unrealize function) 25/27 Checking commit ba43c5895b33 (virtio-snd: Add tx vq and handler) WARNING: line over 80 characters #70: FILE: hw/audio/virtio-snd.c:973: + if (iov_size(elem->in_sg, elem->in_num) < sizeof(virtio_snd_pcm_status) || WARNING: line over 80 characters #71: FILE: hw/audio/virtio-snd.c:974: + iov_size(elem->out_sg, elem->out_num) < sizeof(virtio_snd_pcm_xfer)) { total: 0 errors, 2 warnings, 80 lines checked Patch 25/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/27 Checking commit f13007720379 (virtio-snd: Add event vq and a handler stub) 27/27 Checking commit 28acae83382f (virtio-snd: Add rx vq and stub handler) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to [email protected]
