On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote:
Currently cpu_mips_translate_address() calls raise_mmu_exception(),
and do_translate_address() calls cpu_loop_exit_restore().

This API split is dangerous, we could call cpu_mips_translate_address
without returning to the main loop.

As there is only one caller, it is trivial (and safer) to merge
do_translate_address() back to cpu_mips_translate_address().

Reported-by: Richard Henderson<[email protected]>
Suggested-by: Richard Henderson<[email protected]>
Signed-off-by: Philippe Mathieu-Daudé<[email protected]>
---
  target/mips/internal.h   |  2 +-
  target/mips/op_helper.c  | 20 ++------------------
  target/mips/tlb_helper.c | 11 ++++++-----
  3 files changed, 9 insertions(+), 24 deletions(-)

Reviewed-by: Richard Henderson <[email protected]>

r~

Reply via email to