Previous commit added a check in memory_region_add_subregion_common() to ensure AS root MR can't be added as subregion (changing the MR base address doing so). We can now remove the temporary assert in the raven model.
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/pci-host/raven.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c index d8c1aaa11f5..3f8508bd467 100644 --- a/hw/pci-host/raven.c +++ b/hw/pci-host/raven.c @@ -141,16 +141,6 @@ static const MemoryRegionOps raven_intack_ops = { static inline hwaddr raven_io_address(PREPPCIState *s, hwaddr addr) { - /* - * We shouldn't access AddressSpace internals. However this assert - * is temporarily used to prove a subtle inconsistency from commit - * 1ae1dc5ba24 ("raven: Set a correct PCI I/O memory region") which - * expected the PCI I/O root region base address to be 0x80000000. - * - * We now use an alias memory region as root, which is zero-based. - */ - assert(s->pci_io_as.root->addr == 0); - if (s->contiguous_map == 0) { /* 64 KB contiguous space for IOs */ addr &= 0xFFFF; -- 2.26.3