> -----Original Message-----
> From: Qemu-devel <qemu-devel-
> [email protected]> On Behalf Of Markus
> Armbruster
> Sent: Tuesday, March 23, 2021 5:58 PM
> To: Zhang, Chen <[email protected]>
> Cc: Lukas Straub <[email protected]>; Li Zhijian
> <[email protected]>; Jason Wang <[email protected]>; qemu-
> dev <[email protected]>; Dr. David Alan Gilbert
> <[email protected]>; Zhang Chen <[email protected]>
> Subject: Re: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO
> passthrough
>
> "Zhang, Chen" <[email protected]> writes:
>
> >> -----Original Message-----
> >> From: Markus Armbruster <[email protected]>
> [...]
> >> Now let's look at colo-passthrough-del. I figure it is for deleting
> >> the kind of things colo-passthrough-add adds.
> >>
> >
> > Yes.
> >
> >> What exactly is deleted? The thing created with the exact same
> arguments?
> >>
> >
> > Delete the rule from the module's private bypass list.
> > When user input a rule, the colo-passthrough-del will find the
> > specific module by the object ID, Then delete the rule.
> >
> >> This would be unusual. Commonly, FOO-add and FOO-del both take a
> >> string ID argument. The FOO created by FOO-add remembers its ID, and
> >> FOO-del deletes by ID.
> >
> > The ID not for rules itself, it just logged the modules(ID tagged) affected
> > by
> the rule.
>
> I'm not sure I understand.
>
> If you're pointing out that existing colo-passthrough-del parameter @id is not
> suitable for use as unique rule ID: you can always add another parameter
> that is suitable.
Sorry to missed this mail.
For example:
The VM running with filter-mirror(object id==0), filter-redirector(object
id==1) and colo-compare(object id==2),
We use colo-passthrough-add/del to add/del a rule with a ID, if the ID==2, the
rule just affect to colo-compare.
The filter-mirror and filter-redirector feel nothing after the add/del.
Thanks
Chen
>
