On Mon, Mar 29, 2021 at 10:28 AM Max Reitz <mre...@redhat.com> wrote: > > There are a couple of things pylint takes issue with: > - The "time" import is unused > - The import order (iotests should come last) > - get_bitmap_hash() doesn't use @self and so should be a function > - Semicolons at the end of some lines > - Parentheses after "if" > - Some lines are too long (80 characters instead of 79) > - inject_test_case()'s @name parameter shadows a top-level @name > variable > - "lambda self: mc(self)" is equivalent to just "mc" > - Always put two empty lines after a function > - f'exec: cat > /dev/null' does not need to be an f-string > > Fix them. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > tests/qemu-iotests/tests/migrate-bitmaps-test | 38 ++++++++++--------- > 1 file changed, 20 insertions(+), 18 deletions(-) >
Reviewed-by: Willian Rampazzo <willi...@redhat.com>