Eric Blake <[email protected]> writes: > On 3/16/21 8:59 AM, Markus Armbruster wrote: >> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though >> their external symbols conflict. The linker happens to pick the >> former. This links a bunch of unneeded code into the executables that >> actually want the latter: qemu-io, qemu-img, qemu-nbd, and several >> tests. Amazingly, none of them fails to link. >> >> To fix this, the non-stub yank.c from sourceset util_ss to sourceset > > This sentence no verb.
To fix this, move the non-stub ... >> qmp_ss. This requires moving it from util/ to monitor/. >> >> Suggested-by: Paolo Bonzini <[email protected]> >> Signed-off-by: Markus Armbruster <[email protected]> >> --- >> {util => monitor}/yank.c | 0 >> MAINTAINERS | 2 +- >> monitor/meson.build | 1 + >> util/meson.build | 1 - >> 4 files changed, 2 insertions(+), 2 deletions(-) >> rename {util => monitor}/yank.c (100%) >> > > Reviewed-by: Eric Blake <[email protected]> Thanks!
