> +typedef struct Timings {
> +static void generate_timings(Timings *timings, uint32_t refresh_rate,
> + uint32_t xres, uint32_t yres)
Adding these should be splitted to a separate patch.
> -static void edid_checksum(uint8_t *edid)
> +static void edid_checksum(uint8_t *edid, size_t len)
Why this change? Also a good candidate for a separate patch.
> + if (size >= 384) {
> + did = edid + 256;
"if (size >= 384 && large_screen)" ?
Also setting did should be next to setting dta.
if (did) {
> + dummy_displayid(did);
init_displayid() ?
Especially if we generate that only in case we actually have a large
screen so we never have an empty extension section?
take care,
Gerd
