> -----Original Message----- > From: Richard Henderson <[email protected]> > Sent: Sunday, February 14, 2021 5:41 PM > To: Taylor Simpson <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; Brian Cain <[email protected]> > Subject: Re: [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes > > On 2/7/21 9:46 PM, Taylor Simpson wrote: > > + } else if ((itype == ICLASS_V2LDST) && (GET_ATTRIB(opcode, > A_STORE))) { > > + return SLOTS_01; > > + } else if ((itype == ICLASS_V2LDST) && (!GET_ATTRIB(opcode, > A_STORE))) { > > + return SLOTS_01; > > What's the point of this? Between the two all ICLASS_V2LDST use SLOTS_01. > Why > can't it be done in > > > + return iclass_info[itype];
Good catch - I'll eliminate the unnecessary checks.
