On 10/03/2021 10.11, Paolo Bonzini wrote:
On 10/03/21 10:08, Thomas Huth wrote:
Looks good, I would have moved benchmarks as well but anyway it can be
done separately.
My plan is to move them into a separate directory (tests/bench/) since
this is a separate test suite.
That makes sense indeed.
By the way, "make check-speed" is not working for me anymore (but "make
bench" is working fine) ... and I haven't found out yet what's wrong ...
is it working for you?
No; "make bench" and "make bench-speed" work though.
It's because this filter logic in the generated Makefile.mtest:
bench-speed: run-tests
ifneq ($(filter bench-speed bench, $(MAKECMDGOALS)),)
.tests += $(.test.$(SPEED).bench-speed)
endif
all-bench-targets += bench-speed
... so a quick fix is:
diff a/tests/Makefile.include b/tests/Makefile.include
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -156,6 +156,7 @@ clean: check-clean
# For backwards compatibility
-check-speed: bench-speed
+check-speed:
+ $(MAKE) bench-speed
endif
Thomas
