Re: [PATCH v2] chardev: add nodelay option

[Paolo Bonzini]

On 03/03/21 14:24, Markus Armbruster wrote:

$ qemu-system-x86_64 -chardev socket,id=chr0,path=sock,nodelay=on
qemu-system-x86_64: -chardev socket,id=chr0,path=sock,nodelay=on: Invalid 
parameter 'nodelay'

You forgot to update qemu_chardev_opts:

    diff --git a/chardev/char.c b/chardev/char.c
    index 288efebd12..e6128c046f 100644
    --- a/chardev/char.c
    +++ b/chardev/char.c
    @@ -864,6 +864,9 @@ QemuOptsList qemu_chardev_opts = {
             },{
                 .name = "server",
                 .type = QEMU_OPT_BOOL,
    +        },{
    +            .name = "nodelay",
    +            .type = QEMU_OPT_BOOL,
             },{
                 .name = "delay",
                 .type = QEMU_OPT_BOOL,

Well, I forgot to commit it.  But the outcome is the same.  Thanks. :(

Paolo