On 3/2/21 5:35 AM, Richard Henderson wrote: > On 3/1/21 8:49 AM, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana<[email protected]> >> --- >> target/arm/get-phys-addr.c | 95 ++++++++++++++++++++++++++++++++++++++ >> target/arm/tcg/helper.c | 95 -------------------------------------- >> 2 files changed, 95 insertions(+), 95 deletions(-) > > So... get-phys-addr.c is now gaining stuff not related to get_phys_addr? > What's your end goal? > > Is there a better a better name, like mmu_helper.c? Should these in fact go > into a second file, leaving get-phys-addr to itself? > > > r~ >
These are all good questions; I would like to avoid the word "helper", as it triggers tcg/ HELPER() stuff for me, but I am not excluding it if we don't have a better idea. The alternative to put this stuff into their own file is open for me. Thanks, Claudio
