On 2/24/21 2:25 AM, Richard Henderson wrote: > On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote: >> To easily convert MXU code to decodetree, extract decode_ase_mxu() >> from decode_opc_mxu(), making it return a boolean. >> We will keep decode_opc_mxu() in the translate.c unit because it >> calls gen_arith(). >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> --- >> target/mips/translate.c | 45 ++++++++++++++++++++++++----------------- >> 1 file changed, 26 insertions(+), 19 deletions(-) > > I guess the split is fine until you can just call gen_mul() from a trans() > from > the mxu decodetree.
I expect mxu decodetree to not cover MUL and return false, so it is handled in the base ISA decoder. > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Thanks :)
