On Feb 16 15:16, Keith Busch wrote: > On Mon, Feb 15, 2021 at 12:02:40AM +0100, Klaus Jensen wrote: > > From: Minwoo Im <[email protected]> > > > > Format NVM admin command can make a namespace or namespaces to be > > with different LBA size and metadata size with protection information > > types. > > > > This patch introduces Format NVM command with LBA format, Metadata, and > > Protection Information for the device. The secure erase operation things > > are yet to be added. > > > > The parameter checks inside of this patch has been referred from > > Keith's old branch. > > Oh, and here's the format command now, so my previous comment on patch > 11 doesn't matter. > > > +struct nvme_aio_format_ctx { > > + NvmeRequest *req; > > + NvmeNamespace *ns; > > + > > + /* number of outstanding write zeroes for this namespace */ > > + int *count; > > Shouldn't this count be the NvmeRequest's opaque value?
That is already occupied by `num_formats` which tracks formats of individual namespaces. `count` is for outstanding write zeroes on one particular namespace.
signature.asc
Description: PGP signature
