Hi Alistair
> -----Original Message-----
> From: Alistair Francis <[email protected]>
> Sent: Saturday, February 13, 2021 3:41 AM
> To: Sai Pavan Boddu <[email protected]>
> Cc: Markus Armbruster <[email protected]>; Kevin Wolf
> <[email protected]>; Max Reitz <[email protected]>; Vladimir Sementsov-
> Ogievskiy <[email protected]>; Eric Blake <[email protected]>;
> Joel Stanley <[email protected]>; Cédric Le Goater <[email protected]>; Vincent
> Palatin <[email protected]>; Dr. David Alan Gilbert
> <[email protected]>; Thomas Huth <[email protected]>; Stefan Hajnoczi
> <[email protected]>; Peter Maydell <[email protected]>; Alistair
> Francis <[email protected]>; Edgar Iglesias <[email protected]>; Luc
> Michel <[email protected]>; Paolo Bonzini <[email protected]>;
> Sai Pavan Boddu <[email protected]>; [email protected] Developers
> <[email protected]>; Qemu-block <[email protected]>
> Subject: Re: [RFC PATCH 10/15] sd: emmc: Update CID structure for eMMC
>
> On Thu, Feb 11, 2021 at 12:30 AM Sai Pavan Boddu
> <[email protected]> wrote:
> >
> > CID structure is little different for eMMC, w.r.t to product name and
> > manufacturing date.
> >
> > Signed-off-by: Sai Pavan Boddu <[email protected]>
> > Signed-off-by: Edgar E. Iglesias <[email protected]>
> > ---
> > hw/sd/sd.c | 52 +++++++++++++++++++++++++++++++++++-----------------
> > 1 file changed, 35 insertions(+), 17 deletions(-)
> >
> > diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> > index 7aab647..45311fa 100644
> > --- a/hw/sd/sd.c
> > +++ b/hw/sd/sd.c
> > @@ -345,23 +345,41 @@ static void sd_set_scr(SDState *sd)
> >
> > static void sd_set_cid(SDState *sd)
> > {
> > - sd->cid[0] = MID; /* Fake card manufacturer ID (MID) */
> > - sd->cid[1] = OID[0]; /* OEM/Application ID (OID) */
> > - sd->cid[2] = OID[1];
> > - sd->cid[3] = PNM[0]; /* Fake product name (PNM) */
> > - sd->cid[4] = PNM[1];
> > - sd->cid[5] = PNM[2];
> > - sd->cid[6] = PNM[3];
> > - sd->cid[7] = PNM[4];
> > - sd->cid[8] = PRV; /* Fake product revision (PRV) */
> > - sd->cid[9] = 0xde; /* Fake serial number (PSN) */
> > - sd->cid[10] = 0xad;
> > - sd->cid[11] = 0xbe;
> > - sd->cid[12] = 0xef;
> > - sd->cid[13] = 0x00 | /* Manufacture date (MDT) */
> > - ((MDT_YR - 2000) / 10);
> > - sd->cid[14] = ((MDT_YR % 10) << 4) | MDT_MON;
> > - sd->cid[15] = (sd_crc7(sd->cid, 15) << 1) | 1;
> > + if (sd->emmc) {
> > + sd->cid[0] = MID;
> > + sd->cid[1] = 0x1; /* CBX */
> > + sd->cid[2] = OID[0]; /* OEM/Application ID (OID) */
> > + sd->cid[3] = PNM[0]; /* Fake product name (PNM) 48bit */
> > + sd->cid[4] = PNM[1];
> > + sd->cid[5] = PNM[2];
> > + sd->cid[6] = PNM[3];
> > + sd->cid[7] = PNM[4];
>
> Aren't the majority of these the same between the two cases? It's probably
> cleaner to split them out then.
[Sai Pavan Boddu] Yes, I would try to re-order. If I see only the PNM fields
are same, rest all fields kind of moved a byte below.
Regards,
Sai Pavan
>
> Alistair
>
> > + sd->cid[8] = 0x0;
> > + sd->cid[9] = PRV; /* Fake product revision (PRV) */
> > + sd->cid[10] = 0xde; /* Fake serial number (PSN) */
> > + sd->cid[11] = 0xad;
> > + sd->cid[12] = 0xbe;
> > + sd->cid[13] = 0xef;
> > + sd->cid[14] = ((MDT_YR - 1997) % 0x10); /* MDT */
> > + } else {
> > + sd->cid[0] = MID; /* Fake card manufacturer ID (MID) */
> > + sd->cid[1] = OID[0]; /* OEM/Application ID (OID) */
> > + sd->cid[2] = OID[1];
> > + sd->cid[3] = PNM[0]; /* Fake product name (PNM) 40bit */
> > + sd->cid[4] = PNM[1];
> > + sd->cid[5] = PNM[2];
> > + sd->cid[6] = PNM[3];
> > + sd->cid[7] = PNM[4];
> > + sd->cid[8] = PRV; /* Fake product revision (PRV) */
> > + sd->cid[9] = 0xde; /* Fake serial number (PSN) */
> > + sd->cid[10] = 0xad;
> > + sd->cid[11] = 0xbe;
> > + sd->cid[12] = 0xef;
> > + sd->cid[13] = 0x00 | /* Manufacture date (MDT) */
> > + ((MDT_YR - 2000) / 10);
> > + sd->cid[14] = ((MDT_YR % 10) << 4) | MDT_MON;
> > + }
> > + sd->cid[15] = (sd_crc7(sd->cid, 15) << 1) | 1;
> > }
> >
> > #define HWBLOCK_SHIFT 9 /* 512 bytes */
> > --
> > 2.7.4
> >
> >
