On 2/8/21 12:34 PM, Peter Maydell wrote: > We used to make a distinction between 'float64'/'float32' types and > the 'uint64_t'/'uint32_t' types, requiring special conversion > operations to go between them. We've now dropped this distinction as > unnecessary, and the 'float*' types remain primarily for > documentation purposes when used in places like the function > prototypes of TCG helper functions. > > This means that there's no need for special gdb_get_float64() and > gdb_get_float32() functions to write float64 or float32 values to the > GDB protocol buffer; we can just use gdb_get_reg64() and > gdb_get_reg32(). > > Similarly, for reading a value out of the GDB buffer into a float64 > or float32 we can use ldq_p() or ldl_p() and need not use ldfq_p() > or ldfl_p(). > > This patchseries drops the use of the gdb_get_float* and ldf* > functions from the three targets that were using them, and then > removes the now-unused functions from gdbstub.h and bswap.h. > > thanks > -- PMM > > Peter Maydell (5): > target/sh4: Drop use of gdb_get_float32() and ldfl_p() > target/m68k: Drop use of gdb_get_float64() and ldfq_p() > target/ppc: Drop use of gdb_get_float64() and ldfq_p() > gdbstub: Remove unused gdb_get_float32() and gdb_get_float64() > bswap.h: Remove unused float-access functions > > docs/devel/loads-stores.rst | 14 +++----- > include/exec/cpu-all.h | 8 ----- > include/exec/gdbstub.h | 20 ----------- > include/qemu/bswap.h | 60 --------------------------------- > target/m68k/helper.c | 5 ++- > target/ppc/gdbstub.c | 8 ++--- > target/sh4/gdbstub.c | 8 ++--- > target/ppc/translate_init.c.inc | 4 +-- > 8 files changed, 17 insertions(+), 110 deletions(-)
Series: Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Thanks for the cleanup!
