On Fri, 5 Feb 2021 10:39:21 +0100 Thomas Huth <[email protected]> wrote:
> There is a compiler warning with GCC 9.3 when compiling with > the -fsanitize=thread compiler flag: > > In function 'strncpy', > inlined from 's390x_write_elf64_notes' at > ../target/s390x/arch_dump.c:219:9: > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: > '__builtin_strncpy' specified bound 8 equals destination size > [-Werror=stringop-truncation] > > Since the name should always be NUL-terminated, let's use g_strlcpy() to > silence this warning. And while we're at it, also add an assert() to make > sure that the provided names always fit the size field (which is fine for > the current callers, the function is called once with "CORE" and once with > "LINUX" as a name). > > Signed-off-by: Thomas Huth <[email protected]> > --- > v3: Do not touch the namesz field > > target/s390x/arch_dump.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thanks, applied.
