On 2/4/21 6:39 AM, Claudio Fontana wrote:
> overall, all devices' realize functions take an Error **errp, but return void.
>
> hw/core/qdev.c code, which realizes devices, therefore does:
>
> local_err = NULL;
> dc->realize(dev, &local_err);
> if (local_err != NULL) {
> goto fail;
> }
>
> However, we can improve at least accel_cpu to return a meaningful bool value.
>
> Signed-off-by: Claudio Fontana <[email protected]>
> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> Reviewed-by: Alex Bennée <[email protected]>
> ---
> include/hw/core/accel-cpu.h | 2 +-
> include/qemu/accel.h | 2 +-
> target/i386/host-cpu.h | 2 +-
> accel/accel-common.c | 6 +++---
> cpu.c | 5 +++--
> target/i386/host-cpu.c | 5 +++--
> target/i386/kvm/kvm-cpu.c | 4 ++--
> target/i386/tcg/tcg-cpu.c | 6 ++++--
> 8 files changed, 18 insertions(+), 14 deletions(-)
Reviewed-by: Richard Henderson <[email protected]>
r~
