On Thu, 4 Feb 2021 at 15:39, Programmingkid <[email protected]> wrote: > > > > > On Feb 4, 2021, at 3:54 AM, Paolo Bonzini <[email protected]> wrote: > > > > On 02/02/21 14:44, John Arbuckle wrote: > >> Before switching the build system over to Meson, an icon was > >> added to the QEMU binary on Mac OS. This patch adds back that > >> feature. > >> Signed-off-by: John Arbuckle <[email protected]> > >> --- > >> meson.build | 20 ++++++++++++++++++++ > >> 1 file changed, 20 insertions(+) > >> diff --git a/meson.build b/meson.build > >> index f00b7754fd..7f534f4e75 100644 > >> --- a/meson.build > >> +++ b/meson.build > >> @@ -2183,6 +2183,26 @@ foreach target : target_dirs > >> link_args: link_args, > >> gui_app: exe['gui']) > >> +# set QEMU's icon on Mac OS > >> +if targetos == 'darwin' > >> + newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1', > >> + depends : emulator, > >> + input : emulator, > >> + output : 'new icon for ' + exe_name + ' - 1', > >> + command : ['Rez', '-append', > >> + meson.source_root() + '/pc-bios/qemu.rsrc', '-o', > >> + meson.current_build_dir() / exe['name']], > >> + build_by_default : true) > >> + > >> + custom_target('Icon for ' + exe_name + ' - part 2', > >> + depends : newiconpart1, > >> + input : emulator, > >> + output : 'new icon for ' + exe_name + ' - 2', > >> + command : ['SetFile', '-a', 'C', > >> + meson.current_build_dir() / exe['name']], > >> + build_by_default : true) > >> +endif > >> + > >> if exe_sign > >> emulators += {exe['name'] : custom_target(exe['name'], > >> install: true, > > > > Maybe you can do it on install, using add_install_script instead?
Why would we want to only do it on install? A QEMU which you run from the build tree ought to still have its icon, surely ? -- PMM
