On Wed, Feb 03, 2021 at 10:24:48PM +0800, Bin Meng wrote: > From: Bin Meng <[email protected]> > > At present the <clock-frequency> property of the serial node is > populated with value zero. U-Boot's ns16550 driver is not happy > about this, so let's fill in a meaningful value.
Are you sure this is correct - that is that the serial clock is really the same as the overall system clock? Quite often there's some kind of divider in between. > > Signed-off-by: Bin Meng <[email protected]> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > > --- > > (no changes since v1) > > hw/ppc/e500.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c > index c795276..01517a6 100644 > --- a/hw/ppc/e500.c > +++ b/hw/ppc/e500.c > @@ -126,7 +126,7 @@ static void dt_serial_create(void *fdt, unsigned long > long offset, > qemu_fdt_setprop_string(fdt, ser, "compatible", "ns16550"); > qemu_fdt_setprop_cells(fdt, ser, "reg", offset, 0x100); > qemu_fdt_setprop_cell(fdt, ser, "cell-index", idx); > - qemu_fdt_setprop_cell(fdt, ser, "clock-frequency", 0); > + qemu_fdt_setprop_cell(fdt, ser, "clock-frequency", PLATFORM_CLK_FREQ_HZ); > qemu_fdt_setprop_cells(fdt, ser, "interrupts", 42, 2); > qemu_fdt_setprop_phandle(fdt, ser, "interrupt-parent", mpic); > qemu_fdt_setprop_string(fdt, "/aliases", alias, ser); -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
