On Wed, Feb 3, 2021 at 2:20 PM Samuel Thibault <[email protected]>
wrote:
> Doug Evans, le mer. 03 févr. 2021 13:37:29 -0800, a ecrit:
> > @@ -1392,6 +1392,34 @@ SRST
> > Remove host-to-guest TCP or UDP redirection.
> > ERST
> >
> > +#ifdef CONFIG_SLIRP
> > + {
> > + .name = "ipv6_hostfwd_add",
> > + .args_type = "arg1:s,arg2:s?",
> > + .params = "[netdev_id]
> [tcp|udp]:[hostaddr6]:hostport-[guestaddr6]:guestport",
>
> Perhaps explicit that the IPv6 address should be enclosed with [] ?
>
Yeah, totally open to suggestions for what to write.
I wasn't sure how to do that without getting klunky,
> > + /* Ignore the part between the ']' and addr_sep. */
> > + if (get_str_sep(buf, sizeof(buf), &p, addr_sep) < 0) {
>
> Mmm, I would say that we do not want to just ignore it, and rather make
> sure that it is empty, so that we can possibly make extensions later
> without breaking existing misuse.
>
Completely agree.
