On Mon, Feb 1, 2021 at 9:11 AM Peter Maydell <peter.mayd...@linaro.org> wrote:
> On Fri, 22 Jan 2021 at 00:34, dje--- via <qemu-devel@nongnu.org> wrote: > > > > This is a 10/100 ethernet device that has several features. > > Only the ones needed by the Linux driver have been implemented. > > See npcm7xx_emc.c for a list of unimplemented features. > > > > Reviewed-by: Hao Wu <wuhao...@google.com> > > Reviewed-by: Avi Fishman <avi.fish...@nuvoton.com> > > Signed-off-by: Doug Evans <d...@google.com> > > --- > > docs/system/arm/nuvoton.rst | 3 +- > > hw/arm/npcm7xx.c | 50 +- > > hw/net/meson.build | 1 + > > hw/net/npcm7xx_emc.c | 852 +++++++++++++++++++++++++++++++++ > > hw/net/trace-events | 17 + > > include/hw/arm/npcm7xx.h | 2 + > > include/hw/net/npcm7xx_emc.h | 286 +++++++++++ > > tests/qtest/meson.build | 1 + > > tests/qtest/npcm7xx_emc-test.c | 793 ++++++++++++++++++++++++++++++ > > 9 files changed, 2002 insertions(+), 3 deletions(-) > > create mode 100644 hw/net/npcm7xx_emc.c > > create mode 100644 include/hw/net/npcm7xx_emc.h > > create mode 100644 tests/qtest/npcm7xx_emc-test.c > > Hi; could you split this into a multi-patch series so it's > a bit more digestible to review, please ? > patch 1: new device > patch 2: add new device to the npcm7xx board > patch 3: device test case > > thanks > -- PMM > Done, thx. https://lists.nongnu.org/archive/html/qemu-devel/2021-02/msg00804.html
