Philippe Mathieu-Daudé <[email protected]> writes:

> On Tue, Feb 2, 2021 at 3:23 PM Philippe Mathieu-Daudé <[email protected]> wrote:
>> On 2/2/21 2:39 PM, Alex Bennée wrote:
>> > From: Stefan Weil <[email protected]>
>> >
>> > /bin/true is missing on macOS, but simply "true" is available as a shell 
>> > builtin.
>> >
>> > Signed-off-by: Stefan Weil <[email protected]>
>>
>> Reviewed ... :
>> https://www.mail-archive.com/[email protected]/msg777004.html
>> ... before Peter:
>> https://www.mail-archive.com/[email protected]/msg777010.html
>>
>> > Reviewed-by: Peter Maydell <[email protected]>
>>
>> His tag is and mine isn't... Is it possible this is a b4 bug when
>> names use UTF-8 encoding?
>
> FWIW the version I'm using works:
>
> $ b4 --version
> 0.5.2

Same here... the only thing I can think of was I applied it old style
and your email hadn't been indexed yet (I have Peter's rb in my
review.org). I do generally use b4 to apply series now (as I will this
one when I roll). Sometimes however individual patches get applied
directly if I don't see anything in my email.

It would be nice if b4 could run on across an existing git tree to see
if things can be applied based on tags that may have arrived in the
interim. I think there is a potential race there while a series is
prepared.

> $ b4 am [email protected]
> Looking up https://lore.kernel.org/r/20210128135627.2067003-1-sw%40weilnetz.de
> Grabbing thread from lore.kernel.org/qemu-devel
> Analyzing 4 messages in the thread
> ---
> Writing ./20210128_sw_tests_tcg_replace_bin_true_by_true_required_on_macos.mbx
>  [PATCH] tests/tcg: Replace /bin/true by true (required on macOS)
>    + Reviewed-by: Peter Maydell <[email protected]>
>    + Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> ---
> Total patches: 1
> ---
> Link: https://lore.kernel.org/r/[email protected]
> Base: not found
>       git am 
> ./20210128_sw_tests_tcg_replace_bin_true_by_true_required_on_macos.mbx
>
>> Again:
>> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
>>
>> > Signed-off-by: Alex Bennée <[email protected]>
>> > Message-Id: <[email protected]>
>> > ---
>> >  tests/tcg/Makefile.qemu | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Alex Bennée

Reply via email to