> -----Original Message----- > From: Philippe Mathieu-Daudé <[email protected]> On > Behalf Of Philippe Mathieu-Daudé > Sent: Friday, January 22, 2021 11:54 AM > To: Taylor Simpson <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; Brian Cain <[email protected]> > Subject: Re: [PATCH v7 12/35] Hexagon (target/hexagon) instruction > attributes > > On 1/20/21 4:28 AM, Taylor Simpson wrote: > > Signed-off-by: Taylor Simpson <[email protected]> > > --- > > target/hexagon/attribs.h | 30 ++++++++++++++ > > target/hexagon/attribs_def.h | 95 > ++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 125 insertions(+) > > create mode 100644 target/hexagon/attribs.h > > create mode 100644 target/hexagon/attribs_def.h > > > > diff --git a/target/hexagon/attribs.h b/target/hexagon/attribs.h > > new file mode 100644 > > index 0000000..e88e5eb > > --- /dev/null > > +++ b/target/hexagon/attribs.h > > @@ -0,0 +1,30 @@ > > + > > +enum { > > +#define DEF_ATTRIB(NAME, ...) A_##NAME, > > +#include "attribs_def.h" > > Per QEMU conventions, this file has to be named "attribs_def.h.inc".
Didn't know that. Which files should end in .inc? > > Otherwise: > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Thanks!!
