Philippe Mathieu-Daudé <[email protected]> writes:
> Hi Alex, > > On Fri, Jan 15, 2021 at 2:08 PM Alex Bennée <[email protected]> wrote: >> >> For prettier output. >> >> Signed-off-by: Alex Bennée <[email protected]> >> Reviewed-by: Willian Rampazzo <[email protected]> >> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> >> Message-Id: <[email protected]> >> >> diff --git a/Makefile b/Makefile >> index 0c509a7704..bbab640b31 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -250,8 +250,13 @@ find-src-path = find "$(SRC_PATH)/" -path >> "$(SRC_PATH)/meson" -prune -o \( -name >> >> .PHONY: ctags >> ctags: >> - rm -f "$(SRC_PATH)/"tags >> - $(find-src-path) -exec ctags -f "$(SRC_PATH)/"tags --append {} + >> + $(call quiet-command, \ >> + rm -f "$(SRC_PATH)/"tags, \ >> + "CTAGS", "Remove old tags") >> + $(call quiet-command, \ >> + $(find-src-path) -exec ctags \ >> + -f "$(SRC_PATH)/"tags --append {} +, \ >> + "CTAGS", "Re-index $(SRC_PATH)") >> >> .PHONY: gtags >> gtags: >> -- >> 2.20.1 >> > > Build now fails if ctags is not installed: > > $ if test -n "$MAKE_CHECK_ARGS"; then make -j"$JOBS" $MAKE_CHECK_ARGS ; fi > CTAGS Remove old tags > CTAGS Re-index /builds/philmd/qemu > find: 'ctags': No such file or directory > find: 'ctags': No such file or directory > find: 'ctags': No such file or directory > make: *** [Makefile:254: ctags] Error 1 > make: *** Waiting for unfinished jobs.... Wait what, how? Have you got ctags in your MAKE_CHECK_ARGS? How did it not fail before? I suppose we could add checks for all the tooling in meson but it seems a little overkill for a developer convenience. -- Alex Bennée
