On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote: > tb_gen_code() is only called within TCG accelerator, > declare it locally.
Is this used only in accel/tcg/cpu-exec.c ? Should it be a static function there? Ciao, Claudio > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > accel/tcg/internal.h | 5 +++++ > include/exec/exec-all.h | 5 ----- > accel/tcg/cpu-exec.c | 1 + > accel/tcg/user-exec.c | 1 + > 4 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/accel/tcg/internal.h b/accel/tcg/internal.h > index 4981d98dbfd..f7e18c3498b 100644 > --- a/accel/tcg/internal.h > +++ b/accel/tcg/internal.h > @@ -11,6 +11,11 @@ > > #include "exec/exec-all.h" > > +TranslationBlock *tb_gen_code(CPUState *cpu, > + target_ulong pc, target_ulong cs_base, > + uint32_t flags, > + int cflags); > + > void tb_flush_jmp_cache(CPUState *cpu, target_ulong addr); > > #endif > diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h > index 1e3e7cf8e78..3acc7c2943a 100644 > --- a/include/exec/exec-all.h > +++ b/include/exec/exec-all.h > @@ -64,11 +64,6 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t > searched_pc, bool will_exit); > > void QEMU_NORETURN cpu_loop_exit_noexc(CPUState *cpu); > void QEMU_NORETURN cpu_io_recompile(CPUState *cpu, uintptr_t retaddr); > -TranslationBlock *tb_gen_code(CPUState *cpu, > - target_ulong pc, target_ulong cs_base, > - uint32_t flags, > - int cflags); > - > void QEMU_NORETURN cpu_loop_exit(CPUState *cpu); > void QEMU_NORETURN cpu_loop_exit_restore(CPUState *cpu, uintptr_t pc); > void QEMU_NORETURN cpu_loop_exit_atomic(CPUState *cpu, uintptr_t pc); > diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c > index e0df9b6a1dd..43676ae8d13 100644 > --- a/accel/tcg/cpu-exec.c > +++ b/accel/tcg/cpu-exec.c > @@ -41,6 +41,7 @@ > #include "exec/cpu-all.h" > #include "sysemu/cpu-timers.h" > #include "sysemu/replay.h" > +#include "internal.h" > > /* -icount align implementation. */ > > diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c > index 1215b55ca08..05f3c09cbf9 100644 > --- a/accel/tcg/user-exec.c > +++ b/accel/tcg/user-exec.c > @@ -28,6 +28,7 @@ > #include "qemu/atomic128.h" > #include "trace/trace-root.h" > #include "trace/mem.h" > +#include "internal.h" > > #undef EAX > #undef ECX >
