Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

[Christian Borntraeger]

On 14.01.21 10:10, Christian Borntraeger wrote:
> 
> 
> On 14.01.21 00:58, David Gibson wrote:
> [...]
>> +int s390_pv_init(ConfidentialGuestSupport *cgs, Error **errp)
>> +{
>> +    if (!object_dynamic_cast(OBJECT(cgs), TYPE_S390_PV_GUEST)) {
>> +        return 0;
>> +    }
>> +
>> +    if (!s390_has_feat(S390_FEAT_UNPACK)) {
>> +        error_setg(errp,
>> +                   "CPU model does not support Protected Virtualization");
>> +        return -1;
>> +    }
> 
> I am triggering this and I guess this is because the cpu model is not yet 
> initialized at
> this point in time.
> 
When I remove the check, things seems to work though ( I can access virtio-blk 
devices without
specifying iommu for example)