Re: [PATCH v2] meson: fix Cocoa option in summary

Thu, 07 Jan 2021 03:37:26 -0800 

On 30/12/20 23:16, Chris Hofstaedtler wrote:

Cocoa support was always shown as "no", even it if was enabled.

Fixes: b4e312e953b ("configure: move cocoa option to Meson")
Cc: Paolo Bonzini <[email protected]>
Cc: Peter Maydell <[email protected]>
Cc: Philippe Mathieu-Daudé <[email protected]>
Signed-off-by: Chris Hofstaedtler <[email protected]>
---
  meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 372576f82c..1112ca8fc2 100644
--- a/meson.build
+++ b/meson.build
@@ -2082,7 +2082,7 @@ summary_info += {'strip binaries':    get_option('strip')}
  summary_info += {'profiler':          config_host.has_key('CONFIG_PROFILER')}
  summary_info += {'static build':      config_host.has_key('CONFIG_STATIC')}
  if targetos == 'darwin'
-  summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
+  summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', 
false)}
  endif
  # TODO: add back version
  summary_info += {'SDL support':       sdl.found()}
Using config_host_data makes sense, however "cocoa.found()" is more consistent with the surrounding code. 

Paolo

Reply via email to