Re: [PATCH 03/13] target/mips: Introduce decodetree helpers for MSA LSA/DLSA opcodes

[Richard Henderson]

On 12/8/20 2:36 PM, Philippe Mathieu-Daudé wrote:
>      /* ISA Extensions */
> +#if defined(TARGET_MIPS64)
> +    if (ase_msa_available(env) && decode_msa64(ctx, ctx->opcode)) {
> +        return;
> +    }
> +#endif /* TARGET_MIPS64 */
>      if (ase_msa_available(env) && decode_msa32(ctx, ctx->opcode)) {
>          return;
>      }

Can we reduce the number of ifdefs involved?  Perhaps to zero?

    if (ase_msa) {
       if (TARGET_LONG_BITS == 64 && decode_msa64()) {
           return;
       }
       if (decode_msa32()) {
           return;
       }
    }

I realize this means extra decodetree invocations for mips32, but... does that
really matter?

I suppose some of the tcg expansions could not work for TCGv = TCGv_i32, which
wouldn't help the cause...


r~