On 12/7/20 4:35 PM, Willian Rampazzo wrote:
We could use something more pythonic for this file. Instead of 3
string concatenations, my suggestion is to go with string formatting,
like:
s = "%s, logfile=%s, drain_thread=%s>" % (s, self._logfile, self._drain_thread)
As str is immutable in Python, it avoids unnecessary copies.
Sure, this is fine too. I'm not too worried about performance of
debugging methods.
Alex, use your own discretion -- feel free to keep my RB/ACK and merge
alongside your other tests when ready. Thanks!
--js
