Thomas, Conny, Here is the updated series for the re-IPL fixes mentioned yesterday [1]
I've updated the reviews/acks to Patch 1 (Thank you Conny, Janosch!), and implemented Thomas' suggestion to clear out the memory where S390EP exists early in our processing. This both preserves the delicate balance we have today, and fixes the scenario I've been wrestling with. For this second patch, I opted to #define the address x10008 and use it in both the new memset and existing memcmp, rather than having the address used directly in two places. I put this definition in s390-arch.h as it's shared by both files, even though it's not strictly an "s390 architecture" thing. Considering its importance, it seems like a reasonable fit. Tested with my permutations of virtio/vfio/chreipl/install things, but surely missing some others that I don't have readily configured. [1] https://lore.kernel.org/qemu-devel/[email protected]/ Eric Farman (2): pc-bios: s390x: Ensure Read IPL memory is clean pc-bios: s390x: Clear out leftover S390EP string pc-bios/s390-ccw/dasd-ipl.c | 3 +++ pc-bios/s390-ccw/jump2ipl.c | 2 +- pc-bios/s390-ccw/main.c | 6 ++++++ pc-bios/s390-ccw/s390-arch.h | 3 +++ 4 files changed, 13 insertions(+), 1 deletion(-) -- 2.17.1
