Michael S. Tsirkin <[email protected]> writes:
> On Mon, Nov 16, 2020 at 02:11:35PM +0100, Philippe Mathieu-Daudé wrote: >> On 11/16/20 1:27 PM, Michael S. Tsirkin wrote: >> > On Mon, Nov 16, 2020 at 12:24:15PM +0000, Alex Bennée wrote: >> >> From: Philippe Mathieu-Daudé <[email protected]> >> >> >> >> GCC 9.3.0 thinks that 'method' can be left uninitialized. This code >> >> is already in the "if (bsel || pcihp_bridge_en)" block statement, >> >> but it isn't smart enough to figure it out. >> >> >> >> Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)" >> >> block statement to fix (on Ubuntu): >> >> >> >> ../hw/i386/acpi-build.c: In function 'build_append_pci_bus_devices': >> >> ../hw/i386/acpi-build.c:496:9: error: 'method' may be used uninitialized >> >> in this function [-Werror=maybe-uninitialized] >> >> 496 | aml_append(parent_scope, method); >> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> cc1: all warnings being treated as errors >> >> >> >> Fixes: df4008c9c59 ("piix4: don't reserve hw resources when hotplug is >> >> off globally") >> >> Signed-off-by: Philippe Mathieu-Daudé <[email protected]> >> >> Signed-off-by: Alex Bennée <[email protected]> >> >> Reviewed-by: Igor Mammedov <[email protected]> >> >> Message-Id: <[email protected]> >> >> Message-Id: <[email protected]> >> > >> > BTW it's in my pull request alredy. >> > Not sure why you are merging it too ... >> >> I suppose to unbreak Gitlab-CI... >> >> There is no policy w.r.t. CI so maintainer don't have to use it, >> but this breaking it delay the workflow of others subsystems. >> >> I'm not asking you to use it, just explaining why this patch is >> in Alex's queue. >> >> Regards, >> >> Phil. > > Not sure I understand. > It's in my pull request from Nov 15. I'm not sure how does it > help anyone to also have it in another request from Nov 16... I didn't see your PR had gone in, it shouldn't matter though because git should be smart enough to deal with it being in two places at once. -- Alex Bennée
