Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: [email protected] Subject: [PATCH 0/8] qom: Use qlit to represent property defaults Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 514115e qom: Use qlit to represent property defaults 2ca3561 qom: Make object_property_set_default() public 4c261ae qlit: qlit_type() function 8b601c4 qlit: Support all types of QNums 2d5f1af qnum: qnum_value_is_equal() function be74c49 qnum: QNumValue type for QNum value literals 87b0edc qnum: Make qnum_get_double() get const pointer ab4b510 qobject: Include API docs in docs/devel/qobject.html === OUTPUT BEGIN === 1/8 Checking commit ab4b510c0e22 (qobject: Include API docs in docs/devel/qobject.html) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 total: 0 errors, 1 warnings, 201 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit 87b0edcb50a7 (qnum: Make qnum_get_double() get const pointer) 3/8 Checking commit be74c4978f05 (qnum: QNumValue type for QNum value literals) 4/8 Checking commit 2d5f1af84646 (qnum: qnum_value_is_equal() function) 5/8 Checking commit 8b601c44266e (qlit: Support all types of QNums) ERROR: line over 90 characters #64: FILE: qobject/qlit.c:74: + return qnum_value_is_equal(&lhs->value.qnum, qnum_get_value(qobject_to(QNum, rhs))); total: 1 errors, 0 warnings, 154 lines checked Patch 5/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/8 Checking commit 4c261ae4c3f2 (qlit: qlit_type() function) 7/8 Checking commit 2ca3561ee690 (qom: Make object_property_set_default() public) 8/8 Checking commit 514115e597f1 (qom: Use qlit to represent property defaults) WARNING: Block comments use a leading /* on a separate line #148: FILE: include/qom/property-types.h:33: + /* Note that __VA_ARGS__ can still override .defval */ \ total: 0 errors, 1 warnings, 325 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to [email protected]
