On Sonntag, 1. November 2020 19:02:28 CET Mark Cave-Ayland wrote: > On 01/11/2020 15:12, Christian Schoenebeck wrote: > > Fixes test failures with the 9pfs 'local' tests as discussed with latest > > 9P PR. See the discussion of that PR v2 (Fri, Oct 30th) for details. > > > > In conjunction with Peter Xu's two migration patches (fixing occasional > > lockups of migration tests) overall situation appears to be smooth now: > > https://lore.kernel.org/qemu-devel/20201030135350.GA588069@xz-x1/ > > > > v2->v3: > > - Make the two functions for creating and removing the 9pfs test > > directory > > > > public [NEW patch 1]. > > > > - Place the constructor and destructor functions in virtio-9p-test.c, > > not > > > > in virtio-9p.c, because the latter location would cause the > > constructor > > to be executed whenever libqos is loaded, which would break other, > > completely unrelated tests suites that just link to libqos [patch 2]. > > > > - Previous patch 2 (coverity fix) is already queued, no changes, hence > > > > omitted in this v3. > > > > v1->v2: > > - Added Greg's tested-by tag [patch 1]. > > > > - Log an info-level message if mkdir() failed [patch 2]. > > > > - Update commit log message about coverity being the reporter and > > > > details of the coverity report [patch 2]. > > > > Christian Schoenebeck (2): > > tests/9pfs: make create/remove test dir public > > tests/9pfs: fix test dir for parallel tests > > > > tests/qtest/libqos/virtio-9p.c | 20 ++++++++++---------- > > tests/qtest/libqos/virtio-9p.h | 10 ++++++++++ > > tests/qtest/virtio-9p-test.c | 12 ++++++++++++ > > 3 files changed, 32 insertions(+), 10 deletions(-) > > FWIW one thing I've noticed recently is that my builds for > qemu-system-sparc64 have started giving this warning about a missing > "qtest-9p-local" directory during make check: > > ... > ... > Running test QAPI schema regression tests > Running test qtest-sparc64/endianness-test > Running test qtest-sparc64/prom-env-test > Running test qtest-sparc64/boot-serial-test > Running test qtest-sparc64/cdrom-test > Running test qtest-sparc64/device-introspect-test > Running test qtest-sparc64/machine-none-test > Running test qtest-sparc64/qmp-test > Running test qtest-sparc64/qmp-cmd-test > Running test qtest-sparc64/qom-test > Running test qtest-sparc64/test-hmp > Running test qtest-sparc64/qos-test > rm: cannot remove '/home/build/src/qemu/git/qemu/build/qtest-9p-local': No > such file or directory > TEST iotest-qcow2: 001 > TEST iotest-qcow2: 002 > TEST iotest-qcow2: 003 > TEST iotest-qcow2: 004 > TEST iotest-qcow2: 005 > ... > ... > > Would this get resolved by the changes to the test directory in this > patchset? The build is a simple configure run with > "--target-list=sparc64-softmmu". > > > ATB, > > Mark.
Yes, that should be resolved with the next 9p PR as well, additionally with the following patch that is: https://github.com/cschoenebeck/qemu/commit/603cc76a6069 Thanks for the feedback! Best regards, Christian Schoenebeck
