On 21/10/20 16:46, Claudio Fontana wrote:
> in your respin you have not included my change which surrounds
>
> if (replay_can_snapshot())
>
> around a
>
> if (tcg_enabled()) {
> }
>
> therefore leading to failure of all attempts to snapshot under --disable-tcg.
>
> Alternatively, you can change the stub to return "true"
> (replay_can_snapshot()),
> although its meaning can be quite surprising for the reader under
> --disable-tcg.
Yeah, and it actually makes sense since
return replay_mode == REPLAY_MODE_NONE
|| !replay_has_events();
would always be true.
Paolo
